Reviewing files that changed from the base of the PR and between 4f51892 and 899ca7b.

• app/api/views-dataroom/route.ts (3 hunks)
• app/api/views/route.ts (3 hunks)
• components/analytics/links-table.tsx (3 hunks)
• components/documents/add-document-modal.tsx (4 hunks)
• components/documents/document-header.tsx (4 hunks)
• components/documents/link-analytics.tsx (1 hunks)
• components/links/links-table.tsx (1 hunks)
• components/links/links-visitors.tsx (2 hunks)
• components/view/view-data.tsx (2 hunks)
• components/view/viewer/link-viewer.tsx (1 hunks)
• components/visitors/visitors-table.tsx (3 hunks)
• lib/trigger/export-visits.ts (2 hunks)
• lib/utils/get-file-icon.tsx (2 hunks)
• pages/api/links/[id]/visits.ts (1 hunks)
• pages/api/record_link_click.ts (1 hunks)
• pages/api/teams/[teamId]/documents/[id]/link-analytics.ts (1 hunks)
• pages/api/teams/[teamId]/documents/[id]/views/index.ts (2 hunks)
• pages/documents/[id]/index.tsx (4 hunks)
• prisma/migrations/20250724143745_added_redirect_at/migration.sql (1 hunks)
• prisma/schema/schema.prisma (2 hunks)

prisma/schema/schema.prisma (1)

286-288: LGTM: Well-structured schema addition for link tracking.

The optional redirectAt field is properly typed and documented. The placement within the View model is logical and aligns with the PR's objective to support link-type documents.

prisma/migrations/20250724143745_added_redirect_at/migration.sql (1)

1-2: LGTM: Correct migration for schema update.

The migration properly adds the redirectAt column with appropriate timestamp precision and nullable constraint, matching the schema definition.

components/links/links-table.tsx (1)

899-899: LGTM: Proper conditional prop for link-type documents.

The isLink prop is correctly set based on both targetType and primaryVersion?.type, ensuring proper identification of link documents for specialized rendering.

lib/utils/get-file-icon.tsx (2)

1-1: LGTM: Proper import addition for link icon.

The LinkIcon import is correctly added to support the new link file type case.

---

67-68: LGTM: Consistent file type handling for links.

The new "link" case follows the established pattern and properly returns the LinkIcon with the provided className.

components/analytics/links-table.tsx (4)

25-25: LGTM: Icon import updated for consistency.

The change from Link2Icon to LinkIcon aligns with the icon usage in other components.

---

30-34: LGTM: Improved import organization.

Consolidating utility imports together improves code organization and readability.

---

318-318: LGTM: CSS class reordering.

The class order change doesn't affect functionality and may follow a consistent style guide.

---

368-368: LGTM: Consistent icon usage.

The JSX update to use LinkIcon matches the import change and maintains consistency across components.

components/view/view-data.tsx (1)

28-28: LGTM: Clean import statement

The import follows the established pattern and correctly references the new LinkViewer component.

pages/documents/[id]/index.tsx (4)

15-15: LGTM: Clean import statement

The import follows the established pattern and correctly references the new LinkAnalytics component.

---

93-99: LGTM: Logical exclusion of link documents from stats

The condition correctly excludes both video and link document types from the general StatsComponent, which makes sense as these document types have specialized analytics components.

---

110-116: LGTM: Consistent implementation pattern

The LinkAnalytics conditional rendering follows the same pattern as VideoAnalytics and properly passes all required props. The placement in the component hierarchy is logical.

---

130-130: LGTM: Consistent prop pattern

The addition of the isLink prop follows the same pattern as the existing isVideo prop and enables appropriate handling of link-type documents in the visitors table.

pages/api/teams/[teamId]/documents/[id]/views/index.ts (2)

170-188: LGTM: Well-structured function for link document views

The getLinkViews function follows the established pattern of other view processing functions and appropriately handles link documents with fixed values that make sense for this document type:

• Empty duration data (links don't have page-based viewing)
• Zero total duration (no time-based metrics)
• 100% completion rate (accessing a link is considered complete)

The version matching logic is consistent with existing implementations.

---

319-320: LGTM: Logical conditional placement

The conditional for link documents is appropriately placed in the type-specific handling chain and correctly calls getLinkViews with the proper parameters.

app/api/views/route.ts (2)

101-112: LGTM: Efficient nested query structure

The enhanced Prisma query correctly fetches the document version file data needed for link document handling. The nested structure with proper filtering and selective field retrieval is efficient and well-structured.

---

656-657: LGTM: Correct inclusion of link type

The addition of "link" type to the conditional check ensures that link documents properly return their file data in the API response, which is necessary for the LinkViewer component to function correctly.

pages/api/record_link_click.ts (1)

1-55: Enhance rate limiting and duplicate-click prevention in record_link_click.ts

The endpoint is currently public-by-design for click tracking, but to mitigate abuse you can:

• Add per-IP rate limiting with the existing ratelimit helper
• Extract the client IP via ipAddress(req) from @vercel/functions
• Short-circuit when view.redirectAt is already set to avoid duplicate updates

Example diff:

 import { NextApiRequest, NextApiResponse } from "next";
 import { z } from "zod";
 import prisma from "@/lib/prisma";
 import { log } from "@/lib/utils";
+import { ratelimit } from "@/lib/redis";
+import { ipAddress } from "@vercel/functions";

 export default async function handle(
     req: NextApiRequest,
     res: NextApiResponse,
 ) {
     if (req.method !== "POST") {
         res.status(405).json({ message: "Method Not Allowed" });
         return;
     }

+    // Rate limit by IP
+    const ip = ipAddress(req);
+    const { success } = await ratelimit(10, "1 m").limit(`record-click:${ip}`);
+    if (!success) {
+        return res.status(429).json({ message: "Too many requests" });
+    }

     const { viewId, linkId } = req.body as {
         viewId: string;
         linkId: string;
     };

     const result = bodyValidation.safeParse({ viewId, linkId });
     if (!result.success) {
         return res.status(400).json({ error: `Invalid body: ${result.error.message}` });
     }

     try {
         const link = await prisma.link.findUnique({ where: { id: linkId } });
         if (!link) return res.status(404).json({ message: "Link not found" });

         const view = await prisma.view.findUnique({
             where: { id: viewId },
         });
         if (!view || view.linkId !== linkId) {
             return res.status(404).json({ message: "View not found" });
         }

+        // Prevent duplicate recordings
+        if (view.redirectAt) {
+            return res
+                .status(200)
+                .json({ message: "Click already recorded", view });
+        }

         const updated = await prisma.view.update({
             where: { id: viewId },
             data: { redirectAt: new Date().toISOString() },
         });

         res.status(200).json({ message: "Link click recorded", view: updated });
     } catch (error) {
         log({
             message: `Failed to record link click for ${linkId}.\n\n ${error}`,
             type: "error",
             mention: true,
         });
         res.status(500).json({ message: (error as Error).message });
     }
 }

Please confirm whether this endpoint should remain publicly accessible for tracking (no auth) or if an authentication layer is required.

components/links/links-visitors.tsx (3)

2-2: LGTM! Import additions are appropriate.

The new imports for durationFormat, timeAgo, and BadgeTooltip are necessary for the conditional rendering functionality.

Also applies to: 7-7

---

13-13: LGTM! Prop addition follows best practices.

The isLink prop with a default value of false ensures backward compatibility while enabling the new link-specific functionality.

Also applies to: 17-17

---

42-57: redirectAt field is correctly typed and available

Verified that:

• The Prisma schema defines redirectAt as an optional DateTime? (see prisma/schema/schema.prisma)
• Migration 20250724143745_added_redirect_at adds the column to the View table
• pages/api/record_link_click.ts updates redirectAt on link clicks
• Front-end components (components/links/links-visitors.tsx and components/visitors/visitors-table.tsx) reference view.redirectAt without any TypeScript errors

The conditional rendering for link vs non-link views is clean and the tooltip behavior is spot on. Great work!

components/visitors/visitors-table.tsx (2)

67-67: LGTM! Consistent prop pattern.

The isLink prop follows the same pattern as the LinksVisitors component, maintaining consistency across the codebase.

Also applies to: 71-71

---

143-145: Excellent UX improvement with conditional table header.

The header clearly indicates whether users are viewing "Redirect Time" or "Visit Duration", providing important context for the data displayed.

pages/api/teams/[teamId]/documents/[id]/link-analytics.ts (3)

1-12: LGTM! Clean imports and well-defined interface.

The API response interface is properly typed and the imports are appropriate for the functionality.

---

18-28: LGTM! Proper method validation and authentication.

The authentication flow follows Next.js best practices with appropriate error responses.

---

37-65: Excellent access control and validation logic.

The implementation properly:

• Verifies team membership through the Prisma query
• Validates document existence and access
• Ensures the document is of type "link"
• Returns appropriate HTTP status codes

app/api/views-dataroom/route.ts (3)

123-134: LGTM! Nested selection enables access to linked document files.

The nested query structure properly retrieves the document version file data needed for link-type documents.

---

836-840: Proper handling of link-type document versions.

The logic correctly retrieves the file from the linked document's first version with appropriate null checks.

---

937-938: LGTM! Condition update includes link types appropriately.

Adding "link" to the file return condition ensures link-type documents return their file data consistently with other supported types.

lib/trigger/export-visits.ts (2)

198-198: LGTM! Necessary query addition for document type.

Adding the document type to the query enables the conditional processing logic for link documents.

---

292-398: Excellent conditional processing for link vs non-link documents.

The implementation appropriately handles the fundamental differences:

For link documents:

• Avoids unnecessary Tinybird API calls (performance benefit)
• Uses sensible placeholder values (0 duration, 100% completion)
• Maintains consistent CSV structure

For non-link documents:

• Preserves existing rate-limited API behavior
• Calculates actual duration and completion metrics

The logic is clean, well-structured, and maintains backward compatibility while adding link support.

components/documents/document-header.tsx (4)

540-542: Good refactoring to improve readability and exclude link documents from orientation changes.

The refactoring from explicit inequality comparisons to array membership checks using .includes() makes the code more readable and maintainable. Excluding "link" documents from orientation changes is logical since external links don't have document orientation.

---

565-565: Appropriate exclusion of link documents from version uploads.

Correctly excludes "link" documents from the "Upload new version" functionality, which makes sense since external links cannot have file versions uploaded to them.

---

728-754: Correctly excludes link documents from download-only toggle.

The "Set download only/viewable" option is appropriately excluded for "link" documents since external links inherently redirect users to external sites and cannot be restricted to download-only mode.

---

792-801: Properly excludes link documents from download functionality.

Excluding "link" documents from the "Download latest version" option is correct since external links cannot be downloaded as files. The refactoring also improves code readability.

components/documents/add-document-modal.tsx (5)

75-75: State variable addition follows existing patterns.

The linkUrl state variable is consistent with the existing notionLink pattern and follows React best practices.

---

507-515: Well-implemented URL-to-filename helper function.

Good implementation with proper error handling, sensible fallback behavior, and clean URL parsing logic that removes common prefixes like "www.".

---

639-639: Proper state cleanup for link URL.

Correctly adds linkUrl state reset to the modal state clearing function, maintaining consistency with other state variables.

---

679-682: Clean tab list expansion for link functionality.

Properly updates the tab grid layout and adds the new "Link" tab trigger with appropriate styling and labeling.

---

814-861: Well-structured Link tab implementation.

The new tab content follows established UI patterns with proper form structure, semantic HTML (type="url"), appropriate loading states, and helpful user guidance. The implementation is consistent with existing document and notion tabs.

components/view/viewer/link-viewer.tsx (4)

17-24: Well-implemented domain extraction with proper error handling.

Good performance optimization by placing the function outside the component scope. The error handling and fallback behavior are appropriate for URL parsing.

---

48-61: Excellent use of sendBeacon for reliable link click tracking.

Using navigator.sendBeacon() is the correct approach for tracking as it ensures the request is sent even if the page unloads immediately. The conditional checks and error handling are well implemented.

---

63-68: Robust redirect implementation with duplicate protection.

The use of useCallback, duplicate redirect protection via hasRedirected ref, and window.location.replace() creates a reliable redirect mechanism that prevents issues with browser navigation.

---

70-88: Well-implemented auto-redirect with proper cleanup.

The timer implementation correctly handles component unmounting with the isMounted flag, provides user feedback with countdown updates, and properly cleans up both the timeout and interval to prevent memory leaks.

components/documents/link-analytics.tsx (3)

51-56: Clean implementation of toggle functionality with URL sync.

Properly synchronizes the toggle state with URL parameters, enabling bookmarkable and shareable links. The use of URLSearchParams ensures correct query parameter handling.

---

112-122: Robust analytics calculations with proper null handling.

The calculations correctly handle the redirectAt field specific to link documents, with appropriate filtering, sorting, and type checking for edge cases.

---

124-142: Well-structured statistics with appropriate formatting.

The statistics are properly configured for link documents with human-readable time formatting and appropriate handling of cases where no redirections have occurred.

pages/api/links/[id]/visits.ts (4)

18-21: Good early method validation with proper HTTP response.

Adding upfront method validation with appropriate headers and status codes is a good practice that prevents unnecessary processing.

---

32-66: Improved query structure with proper validation.

Good additions including the document type field in the query, explicit document existence checking, and appropriate 404 responses for missing documents.

---

96-131: Appropriate conditional handling for link documents.

The conditional logic correctly handles link documents by providing appropriate placeholder values (empty duration data, 100% completion rate) while maintaining existing functionality for other document types.

---

133-140: Consistent response structure and error handling.

The response maintains the expected data structure while preserving robust error handling and logging patterns.